Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement OIDC auth workflow in UI #7121

Merged
merged 5 commits into from
Jan 5, 2022
Merged

Implement OIDC auth workflow in UI #7121

merged 5 commits into from
Jan 5, 2022

Conversation

joshigaurava
Copy link
Contributor

Description

UI can now recognize and carry out OIDC auth workflow

Upgrade Notes

Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

  • Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

  • Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

  • New configuration options
  • Deprecation of configurations
  • Signature changes to public methods/interfaces
  • New plugins added or old plugins removed
  • Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

@joshigaurava joshigaurava changed the title Implemented OIDC auth workflow in UI Implement OIDC auth workflow in UI Jul 2, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2021

Codecov Report

Merging #7121 (929041f) into master (f2f8e38) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7121      +/-   ##
============================================
+ Coverage     71.28%   71.36%   +0.07%     
  Complexity     4201     4201              
============================================
  Files          1595     1595              
  Lines         82614    82614              
  Branches      12330    12330              
============================================
+ Hits          58890    58956      +66     
+ Misses        19740    19678      -62     
+ Partials       3984     3980       -4     
Flag Coverage Δ
integration1 29.06% <ø> (+0.17%) ⬆️
integration2 27.65% <ø> (-0.01%) ⬇️
unittests1 68.20% <ø> (-0.02%) ⬇️
unittests2 14.28% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../helix/core/realtime/SegmentCompletionManager.java 72.00% <0.00%> (-0.82%) ⬇️
.../aggregation/function/ModeAggregationFunction.java 87.83% <0.00%> (-0.82%) ⬇️
...a/org/apache/pinot/core/common/DataBlockCache.java 92.10% <0.00%> (+0.65%) ⬆️
...nMaxValueBasedSelectionOrderByCombineOperator.java 72.72% <0.00%> (+0.75%) ⬆️
...ata/manager/realtime/RealtimeTableDataManager.java 68.69% <0.00%> (+0.81%) ⬆️
.../pinot/core/query/scheduler/PriorityScheduler.java 83.56% <0.00%> (+2.73%) ⬆️
...nction/DistinctCountBitmapAggregationFunction.java 52.84% <0.00%> (+6.21%) ⬆️
...altime/ServerSegmentCompletionProtocolHandler.java 58.09% <0.00%> (+6.66%) ⬆️
...data/manager/realtime/SegmentCommitterFactory.java 100.00% <0.00%> (+11.76%) ⬆️
...er/api/resources/LLCSegmentCompletionHandlers.java 62.37% <0.00%> (+18.81%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2f8e38...929041f. Read the comment docs.

@joshigaurava joshigaurava marked this pull request as ready for review July 30, 2021 00:02
Copy link
Contributor

@apucher apucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Gaurav!

@apucher apucher merged commit 3c4285b into apache:master Jan 5, 2022
@joshigaurava joshigaurava deleted the oidc-ui branch January 5, 2022 20:28
@joshigaurava joshigaurava restored the oidc-ui branch January 5, 2022 20:28
@joshigaurava joshigaurava deleted the oidc-ui branch June 20, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants